-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Describe parametric images above the suffix table, rather than below #1687
Merged
Remi-Gau
merged 5 commits into
bids-standard:master
from
CPernet:Clarify-Parametric-structural-MR-images
Feb 19, 2024
Merged
[ENH] Describe parametric images above the suffix table, rather than below #1687
Remi-Gau
merged 5 commits into
bids-standard:master
from
CPernet:Clarify-Parametric-structural-MR-images
Feb 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python style failure is unrelated: due to the new black release. Will PR to fix. |
Remi-Gau
reviewed
Jan 26, 2024
Remi-Gau
reviewed
Jan 26, 2024
CPernet
commented
Jan 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for the update pal
effigies
reviewed
Feb 16, 2024
effigies
approved these changes
Feb 16, 2024
effigies
changed the title
just moving information to be more visible
[ENH] Describe parametric images above the suffix table, rather than below
Feb 16, 2024
Remi-Gau
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #1683 information above the table (people do not read what is under - add few common examples to grab attention)
I think the annex table could benefit from having OPTIONAL and MANDATORY for entities, but trough the macro it would break over tables I think (I looked at it and for scared lol)